drm/panel: k101-im2ba02: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Thu, 16 Sep 2021 10:42:47 +0000 (18:42 +0800)
committerSam Ravnborg <sam@ravnborg.org>
Thu, 14 Oct 2021 20:09:22 +0000 (22:09 +0200)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Icenowy Zheng <icenowy@aosc.io>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104247.11270-1-caihuoqing@baidu.com
drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c

index 2a602ae..cb0bb30 100644 (file)
@@ -456,16 +456,13 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi)
 
        ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
                                      ctx->supplies);
-       if (ret < 0) {
-               dev_err(&dsi->dev, "Couldn't get regulators\n");
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(&dsi->dev, ret, "Couldn't get regulators\n");
 
        ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW);
-       if (IS_ERR(ctx->reset)) {
-               dev_err(&dsi->dev, "Couldn't get our reset GPIO\n");
-               return PTR_ERR(ctx->reset);
-       }
+       if (IS_ERR(ctx->reset))
+               return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset),
+                                    "Couldn't get our reset GPIO\n");
 
        drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs,
                       DRM_MODE_CONNECTOR_DSI);