MIPS: ralink: mt7621: use bitwise NOT instead of logical
authorIlya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Tue, 1 Mar 2022 01:15:07 +0000 (17:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Mar 2022 18:12:52 +0000 (19:12 +0100)
[ Upstream commit 5d8965704fe5662e2e4a7e4424a2cbe53e182670 ]

It was the intention to reverse the bits, not make them all zero by
using logical NOT operator.

Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1")
Suggested-by: Chuanhong Guo <gch981213@gmail.com>
Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/mips/ralink/mt7621.c

index fd9a872..4c83786 100644 (file)
@@ -38,7 +38,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size)
        __raw_writel(MT7621_MEM_TEST_PATTERN, dm);
        if (__raw_readl(dm) != __raw_readl(dm + size))
                return false;
-       __raw_writel(!MT7621_MEM_TEST_PATTERN, dm);
+       __raw_writel(~MT7621_MEM_TEST_PATTERN, dm);
        return __raw_readl(dm) == __raw_readl(dm + size);
 }