usbip: Fix vep_free_request() null pointer checks on input args
authorShuah Khan <shuah@kernel.org>
Fri, 25 Jan 2019 16:05:42 +0000 (09:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Jan 2019 08:22:35 +0000 (09:22 +0100)
Fix vep_free_request() to return when usb_ep and usb_request are null
instead of calling WARN_ON.

Signed-off-by: Shuah Khan <shuah@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/vudc_dev.c

index 1634d86..a72c17f 100644 (file)
@@ -297,7 +297,8 @@ static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req)
 {
        struct vrequest *req;
 
-       if (WARN_ON(!_ep || !_req))
+       /* ep is always valid here - see usb_ep_free_request() */
+       if (!_req)
                return;
 
        req = to_vrequest(_req);