rethook: Fix to use WRITE_ONCE() for rethook:: Handler
authorMasami Hiramatsu <mhiramat@kernel.org>
Thu, 31 Mar 2022 01:11:17 +0000 (10:11 +0900)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 31 Mar 2022 02:28:17 +0000 (19:28 -0700)
Since the function pointered by rethook::handler never be removed when
the rethook is alive, it doesn't need to use rcu_assign_pointer() to
update it. Just use WRITE_ONCE().

Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/164868907688.21983.1606862921419988152.stgit@devnote2
kernel/trace/rethook.c

index ab463a4..b568337 100644 (file)
@@ -65,7 +65,7 @@ static void rethook_free_rcu(struct rcu_head *head)
  */
 void rethook_free(struct rethook *rh)
 {
-       rcu_assign_pointer(rh->handler, NULL);
+       WRITE_ONCE(rh->handler, NULL);
 
        call_rcu(&rh->rcu, rethook_free_rcu);
 }