drivers/staging: adjust double test
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 12 Jan 2012 21:49:27 +0000 (22:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2012 17:13:55 +0000 (09:13 -0800)
Rewrite a duplicated test to test the correct value

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_rx.c

index 6c5061f..13979b5 100644 (file)
@@ -2453,7 +2453,7 @@ static inline void update_network(struct rtllib_network *dst,
        if (src->wmm_param[0].ac_aci_acm_aifsn ||
           src->wmm_param[1].ac_aci_acm_aifsn ||
           src->wmm_param[2].ac_aci_acm_aifsn ||
-          src->wmm_param[1].ac_aci_acm_aifsn)
+          src->wmm_param[3].ac_aci_acm_aifsn)
                memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN);
 
        dst->SignalStrength = src->SignalStrength;