Revert "actor: Unconditionally set show_on_set_parent"
authorEmmanuele Bassi <ebassi@linux.intel.com>
Thu, 26 Apr 2012 13:02:07 +0000 (14:02 +0100)
committerEmmanuele Bassi <ebassi@linux.intel.com>
Thu, 26 Apr 2012 13:02:07 +0000 (14:02 +0100)
This reverts commit 81b19a78f5e02ae8ffd9235054d80b172496415b.

The commit breaks the conformance test unit for the invariants we
guarantee for the 1.x API:

ERROR:actor-invariants.c:307:actor_show_on_set_parent: assertion failed: (show_on_set_parent)

clutter/clutter-actor.c

index a05d46b..988d462 100644 (file)
@@ -1554,9 +1554,12 @@ set_show_on_set_parent (ClutterActor *self,
   if (priv->show_on_set_parent == set_show)
     return;
 
-  priv->show_on_set_parent = set_show;
-  g_object_notify_by_pspec (G_OBJECT (self),
-                            obj_props[PROP_SHOW_ON_SET_PARENT]);
+  if (priv->parent == NULL)
+    {
+      priv->show_on_set_parent = set_show;
+      g_object_notify_by_pspec (G_OBJECT (self),
+                                obj_props[PROP_SHOW_ON_SET_PARENT]);
+    }
 }
 
 /**