Revert "net: gem: Disable broadcast setting"
authorMichal Simek <michal.simek@xilinx.com>
Fri, 14 Jan 2022 12:15:48 +0000 (13:15 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Mon, 17 Jan 2022 09:01:51 +0000 (10:01 +0100)
This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67.

The main reason is that QEMU is using BOOTP protocol which is sending DHCP
Offer to a broadcast address that's why it can't be disabled.
DHCP protocol has no issue because it returns directly to client MAC
address.
Both of these options are described in RFC951
(https://datatracker.ietf.org/doc/html/rfc951#section-4)

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Link: https://lore.kernel.org/r/fc5f5e2aeca77847ed4ca6a263890375ab9f5163.1642162545.git.michal.simek@xilinx.com
drivers/net/zynq_gem.c

index b751d28..2c27ffd 100644 (file)
@@ -62,7 +62,6 @@
 #define ZYNQ_GEM_NWCFG_SPEED100                0x00000001 /* 100 Mbps operation */
 #define ZYNQ_GEM_NWCFG_SPEED1000       0x00000400 /* 1Gbps operation */
 #define ZYNQ_GEM_NWCFG_FDEN            0x00000002 /* Full Duplex mode */
-#define ZYNQ_GEM_NWCFG_NO_BRDC         BIT(5) /* No broadcast */
 #define ZYNQ_GEM_NWCFG_FSREM           0x00020000 /* FCS removal */
 #define ZYNQ_GEM_NWCFG_SGMII_ENBL      0x08000000 /* SGMII Enable */
 #define ZYNQ_GEM_NWCFG_PCS_SEL         0x00000800 /* PCS select */
@@ -80,7 +79,6 @@
 
 #define ZYNQ_GEM_NWCFG_INIT            (ZYNQ_GEM_DBUS_WIDTH | \
                                        ZYNQ_GEM_NWCFG_FDEN | \
-                                       ZYNQ_GEM_NWCFG_NO_BRDC | \
                                        ZYNQ_GEM_NWCFG_FSREM | \
                                        ZYNQ_GEM_NWCFG_MDCCLKDIV)