fix silent failure on Windows builds (#16984)
authorKarl Ostmo <kostmo@fb.com>
Tue, 12 Feb 2019 18:41:45 +0000 (10:41 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 12 Feb 2019 19:06:27 +0000 (11:06 -0800)
Summary:
Closes #16983

Remove backticks that are being interpreted by the shell. Add -e option to bash script to avoid future such failures
Pull Request resolved: https://github.com/pytorch/pytorch/pull/16984

Reviewed By: yf225

Differential Revision: D14039128

Pulled By: kostmo

fbshipit-source-id: c31a1895377ca86c1b59e79351843cc8c4fd7de3

.jenkins/pytorch/win-test.sh

index ba1a4c9..2a6b647 100755 (executable)
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/bash -e
 
 COMPACT_JOB_NAME=pytorch-win-ws2016-cuda9-cudnn7-py3-test
 source "$(dirname "${BASH_SOURCE[0]}")/common.sh"
@@ -75,7 +75,7 @@ set PYTHONPATH=%TMP_DIR_WIN%\\build;%PYTHONPATH%
 if NOT "%BUILD_ENVIRONMENT%"=="" (
     cd %TMP_DIR_WIN%\\build
     python %TMP_DIR_WIN%\\ci_scripts\\download_image.py %TMP_DIR_WIN%\\%IMAGE_COMMIT_TAG%.7z
-    :: 7z: `-aos` skips if exists because this .bat can be called multiple times
+    :: 7z: -aos skips if exists because this .bat can be called multiple times
     7z x %TMP_DIR_WIN%\\%IMAGE_COMMIT_TAG%.7z -aos
     cd %WORKING_DIR%
 ) else (