ubifs: journal: Fix error return code in ubifs_jnl_write_inode()
authorZhen Lei <thunder.leizhen@huawei.com>
Sat, 8 May 2021 03:33:13 +0000 (11:33 +0800)
committerRichard Weinberger <richard@nod.at>
Fri, 18 Jun 2021 20:04:47 +0000 (22:04 +0200)
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 9ca2d7326444 ("ubifs: Limit number of xattrs per inode")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/journal.c

index 2857e64d673d1db441849c6759c4c1927929448a..230717384a38eca4a9561c0c83a455572d78b0be 100644 (file)
@@ -882,6 +882,7 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode)
                struct ubifs_dent_node *xent, *pxent = NULL;
 
                if (ui->xattr_cnt > ubifs_xattr_max_cnt(c)) {
+                       err = -EPERM;
                        ubifs_err(c, "Cannot delete inode, it has too much xattrs!");
                        goto out_release;
                }