coverity error handling 42/173842/2
authordeepti <d.saraswat@samsung.com>
Mon, 26 Mar 2018 07:04:48 +0000 (12:34 +0530)
committerjaekuk lee <juku1999@samsung.com>
Tue, 27 Mar 2018 00:27:39 +0000 (00:27 +0000)
This patch checked function return value to avoid unneccessary conditions.

Coverity:110226

Change-Id: Ifb92a67c65aa52d9010b4ec0b107b0e44ab6a9f6
Signed-off-by: deepti <d.saraswat@samsung.com>
src/node/gcontext.cpp

index b52edbe82901bef325357fecd2408d8cfa6fcd27..b6d559751efd42821ebd6f3d796335747ecfceb7 100644 (file)
@@ -46,7 +46,6 @@ GContext::~GContext(){
 void GContext::Init(){
     if(initialized_)
         return;
-    initialized_ = true;
 
     GMainContext *gc = g_main_context_default();
 
@@ -54,7 +53,10 @@ void GContext::Init(){
     g_type_init();
 #endif
 
-    g_main_context_acquire(gc);
+    if(!g_main_context_acquire(gc))
+        return;
+
+    initialized_ = true;
     context_ = g_main_context_ref(gc);
     fd_list_ = NULL;
     fd_list_size_ = 0;