drm/omap: drop unused dsi.configure_pins
authorSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 15 Dec 2020 10:45:35 +0000 (12:45 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 15 Dec 2020 14:07:28 +0000 (16:07 +0200)
The panel-dsi-cm's ddata->pin_config is always NULL, so this
callback is never called. Instead the DSI encoder gets the pin
configuration directly from DT.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215104657.802264-3-tomi.valkeinen@ti.com
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
drivers/gpu/drm/omapdrm/dss/dsi.c
drivers/gpu/drm/omapdrm/dss/omapdss.h

index e39ce0c..458cadb 100644 (file)
@@ -68,8 +68,6 @@ struct panel_drv_data {
        int width_mm;
        int height_mm;
 
-       struct omap_dsi_pin_config pin_config;
-
        /* runtime variables */
        bool enabled;
 
@@ -623,15 +621,6 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
                }
        }
 
-       if (ddata->pin_config.num_pins > 0) {
-               r = src->ops->dsi.configure_pins(src, &ddata->pin_config);
-               if (r) {
-                       dev_err(&ddata->pdev->dev,
-                               "failed to configure DSI pins\n");
-                       goto err_vddi;
-               }
-       }
-
        r = src->ops->dsi.set_config(src, &dsi_config);
        if (r) {
                dev_err(&ddata->pdev->dev, "failed to configure DSI\n");
index 735a4e9..2ba1287 100644 (file)
@@ -4890,7 +4890,6 @@ static const struct omap_dss_device_ops dsi_ops = {
 
                .enable_hs = dsi_vc_enable_hs,
 
-               .configure_pins = dsi_configure_pins,
                .set_config = dsi_set_config,
 
                .enable_video_output = dsi_enable_video_output,
index 47763e0..d12c77e 100644 (file)
@@ -296,8 +296,6 @@ struct omapdss_dsi_ops {
        /* bus configuration */
        int (*set_config)(struct omap_dss_device *dssdev,
                        const struct omap_dss_dsi_config *cfg);
-       int (*configure_pins)(struct omap_dss_device *dssdev,
-                       const struct omap_dsi_pin_config *pin_cfg);
 
        void (*enable_hs)(struct omap_dss_device *dssdev, int channel,
                        bool enable);