iwlwifi: mvm: fail temp test enabling if the ucode is not loaded
authorLuciano Coelho <luciano.coelho@intel.com>
Wed, 20 Aug 2014 07:21:07 +0000 (10:21 +0300)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 14 Sep 2014 09:56:38 +0000 (12:56 +0300)
If the ucode is not loaded, don't allow the temperature test to be
started, but allow it to be changed or stopped if already running.

Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/mvm/debugfs.c

index d98ee10..85eb847 100644 (file)
@@ -288,6 +288,9 @@ static ssize_t iwl_dbgfs_set_nic_temperature_write(struct iwl_mvm *mvm,
 {
        int temperature;
 
+       if (!mvm->ucode_loaded && !mvm->temperature_test)
+               return -EIO;
+
        if (kstrtoint(buf, 10, &temperature))
                return -EINVAL;
        /* not a legal temperature */