cpufreq: remove unnecessary cpufreq_cpu_{get|put}() calls
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 31 May 2013 06:15:08 +0000 (06:15 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 4 Jun 2013 12:26:27 +0000 (14:26 +0200)
struct cpufreq_policy is already passed as argument to some routines
like: __cpufreq_driver_getavg() and so we don't really need to do
cpufreq_cpu_get() before and cpufreq_cpu_put() in them to get a
policy structure.

Remove them.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index ce9273a..f8c2860 100644 (file)
@@ -1572,10 +1572,6 @@ int cpufreq_driver_target(struct cpufreq_policy *policy,
 {
        int ret = -EINVAL;
 
-       policy = cpufreq_cpu_get(policy->cpu);
-       if (!policy)
-               goto no_policy;
-
        if (unlikely(lock_policy_rwsem_write(policy->cpu)))
                goto fail;
 
@@ -1584,30 +1580,19 @@ int cpufreq_driver_target(struct cpufreq_policy *policy,
        unlock_policy_rwsem_write(policy->cpu);
 
 fail:
-       cpufreq_cpu_put(policy);
-no_policy:
        return ret;
 }
 EXPORT_SYMBOL_GPL(cpufreq_driver_target);
 
 int __cpufreq_driver_getavg(struct cpufreq_policy *policy, unsigned int cpu)
 {
-       int ret = 0;
-
        if (cpufreq_disabled())
-               return ret;
+               return 0;
 
        if (!cpufreq_driver->getavg)
                return 0;
 
-       policy = cpufreq_cpu_get(policy->cpu);
-       if (!policy)
-               return -EINVAL;
-
-       ret = cpufreq_driver->getavg(policy, cpu);
-
-       cpufreq_cpu_put(policy);
-       return ret;
+       return cpufreq_driver->getavg(policy, cpu);
 }
 EXPORT_SYMBOL_GPL(__cpufreq_driver_getavg);