media: camss: ispif: Remove redundant dev_err call in msm_ispif_subdev_init()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 9 Apr 2021 05:06:33 +0000 (07:06 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 11:17:10 +0000 (13:17 +0200)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/camss/camss-ispif.c

index a30e453de1628142658338d54f9090a888923006..37611c8861da9ed4a4f7270304c637b6958d24b0 100644 (file)
@@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
 
        r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
        ispif->base = devm_ioremap_resource(dev, r);
-       if (IS_ERR(ispif->base)) {
-               dev_err(dev, "could not map memory\n");
+       if (IS_ERR(ispif->base))
                return PTR_ERR(ispif->base);
-       }
 
        r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
        ispif->base_clk_mux = devm_ioremap_resource(dev, r);
-       if (IS_ERR(ispif->base_clk_mux)) {
-               dev_err(dev, "could not map memory\n");
+       if (IS_ERR(ispif->base_clk_mux))
                return PTR_ERR(ispif->base_clk_mux);
-       }
 
        /* Interrupt */