mlxsw: spectrum_router: Adjust mlxsw_sp_inetaddr_vlan_event() coding style
authorPetr Machata <petrm@nvidia.com>
Thu, 13 Jul 2023 16:15:27 +0000 (18:15 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Jul 2023 09:20:15 +0000 (10:20 +0100)
The bridge branch of the dispatch in this function is going to get more
code and will need curly braces. Per the doctrine, that means the whole
if-else chain should get them.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Danielle Ratson <danieller@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

index e840ca9..3a51032 100644 (file)
@@ -8877,15 +8877,17 @@ static int mlxsw_sp_inetaddr_vlan_event(struct mlxsw_sp *mlxsw_sp,
        if (netif_is_bridge_port(vlan_dev))
                return 0;
 
-       if (mlxsw_sp_port_dev_check(real_dev))
+       if (mlxsw_sp_port_dev_check(real_dev)) {
                return mlxsw_sp_inetaddr_port_vlan_event(vlan_dev, real_dev,
                                                         event, vid, extack);
-       else if (netif_is_lag_master(real_dev))
+       } else if (netif_is_lag_master(real_dev)) {
                return __mlxsw_sp_inetaddr_lag_event(vlan_dev, real_dev, event,
                                                     vid, extack);
-       else if (netif_is_bridge_master(real_dev) && br_vlan_enabled(real_dev))
+       } else if (netif_is_bridge_master(real_dev) &&
+                  br_vlan_enabled(real_dev)) {
                return mlxsw_sp_inetaddr_bridge_event(mlxsw_sp, vlan_dev, event,
                                                      extack);
+       }
 
        return 0;
 }