elm_map: Fixed a leak when ecore_file_download_full fails
authorRajesh PS <rajeshps@samsung.com>
Thu, 3 Apr 2014 10:16:14 +0000 (19:16 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 3 Apr 2014 10:16:14 +0000 (19:16 +0900)
Summary:
The url variable used for ecore_file_download_full api was not being freed when the api failed

@fix

Test Plan: elementary_test->map

Reviewers: seoz, daniel, raster

Reviewed By: raster

CC: govi
Differential Revision: https://phab.enlightenment.org/D692

AUTHORS
src/lib/elm_authors.h
src/lib/elm_map.c

diff --git a/AUTHORS b/AUTHORS
index 9bd2402..d291cb8 100644 (file)
--- a/AUTHORS
+++ b/AUTHORS
@@ -152,3 +152,4 @@ suxia li <suxia.li@samsung.com>
 yan.wang <yan.wang@linux.intel.com>
 Anand <anand.km@samsung.com>
 Subhransu Sekhar Mohanty <sub.mohanty@samsung.com>
+Rajesh P S <rajeshps@samsung.com>
index f17abaa..a7aee5f 100644 (file)
  * @author yan.wang <yan.wang@@linux.intel.com>
  * @author Anand <anand.km@@samsung.com>
  * @author Subhransu Sekhar Mohanty <sub.mohanty@@samsung.com>
+ * @author Rajesh P S <rajeshps@@samsung.com>
  *
  * Please contact <enlightenment-devel@lists.sourceforge.net> to get in
  * contact with the developers and maintainers.
index 59ade2d..d0fe739 100644 (file)
@@ -3121,6 +3121,7 @@ _name_request(const Evas_Object *obj,
         free(name->fname);
         free(name);
         free(fname);
+        free(url);
         return NULL;
      }
    INF("Name requested from %s to %s", url, name->fname);
@@ -3174,6 +3175,7 @@ _name_list_request(const Evas_Object *obj,
         ERR("Can't request Name from %s to %s", url, name_list->fname);
         free(name_list->fname);
         free(name_list);
+        free(url);
         free(fname);
         return NULL;
      }
@@ -4393,6 +4395,7 @@ _elm_map_route_add(Eo *obj, Elm_Map_Data *sd, Elm_Map_Route_Type type, Elm_Map_R
         ERR("Can't request Route from %s to %s", url, route->fname);
         free(route->fname);
         free(route);
+        free(url);
         return ret;
      }
    INF("Route requested from %s to %s", url, route->fname);