block: assign correct tag before doing prefetch of request
authorJens Axboe <axboe@kernel.dk>
Mon, 1 Nov 2021 12:56:09 +0000 (06:56 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 2 Nov 2021 12:57:20 +0000 (06:57 -0600)
Ensure that current tag is correctly assigned before attempting
to prefetch the first cacheline of the request.

Fixes: 92aff191cc5b ("block: prefetch request to be initialized")
Reported-and-tested-by: syzbot+cd20829ac44b92bf6ed0@syzkaller.appspotmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c

index 221d1b7..4787d5b 100644 (file)
@@ -405,8 +405,8 @@ __blk_mq_alloc_requests_batch(struct blk_mq_alloc_data *data,
        for (i = 0; tag_mask; i++) {
                if (!(tag_mask & (1UL << i)))
                        continue;
-               prefetch(tags->static_rqs[tag]);
                tag = tag_offset + i;
+               prefetch(tags->static_rqs[tag]);
                tag_mask &= ~(1UL << i);
                rq = blk_mq_rq_ctx_init(data, tags, tag, alloc_time_ns);
                rq_list_add(data->cached_rq, rq);