clk: at91: clk-sam9x60-pll: fix return value check
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Mon, 27 Feb 2023 10:59:31 +0000 (12:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:32 +0000 (23:03 +0900)
[ Upstream commit 1bd8e27fd0db0fe7f489213836dcbab92934f8fa ]

sam9x60_frac_pll_compute_mul_frac() can't return zero. Remove the check
against zero to reflect this.

Fixes: 43b1bb4a9b3e ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230227105931.2812412-1-claudiu.beznea@microchip.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/at91/clk-sam9x60-pll.c

index d757003..0882ed0 100644 (file)
@@ -668,7 +668,7 @@ sam9x60_clk_register_frac_pll(struct regmap *regmap, spinlock_t *lock,
 
                ret = sam9x60_frac_pll_compute_mul_frac(&frac->core, FCORE_MIN,
                                                        parent_rate, true);
-               if (ret <= 0) {
+               if (ret < 0) {
                        hw = ERR_PTR(ret);
                        goto free;
                }