Revert "drm/i915: Use a dmi quirk to skip a broken SDVO TV output."
authorZhenyu Wang <zhenyuw@linux.intel.com>
Mon, 29 Mar 2010 15:16:13 +0000 (23:16 +0800)
committerEric Anholt <eric@anholt.net>
Mon, 12 Apr 2010 16:23:59 +0000 (09:23 -0700)
This reverts commit 6070a4a928f8c92b9fae7d6717ebbb05f425d6b2.

The quirk for this SDVO device on IBM specific board is just a hack
in old code which showed the broken multifunction SDVO support in
the driver. Multifunction SDVO patch provided the right fix for it.

Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/intel_sdvo.c

index 5628de2..1f4e9e9 100644 (file)
@@ -35,7 +35,6 @@
 #include "i915_drm.h"
 #include "i915_drv.h"
 #include "intel_sdvo_regs.h"
-#include <linux/dmi.h>
 
 #define SDVO_TMDS_MASK (SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_TMDS1)
 #define SDVO_RGB_MASK  (SDVO_OUTPUT_RGB0 | SDVO_OUTPUT_RGB1)
@@ -2179,25 +2178,6 @@ intel_sdvo_get_slave_addr(struct drm_device *dev, int sdvo_reg)
                return 0x72;
 }
 
-static int intel_sdvo_bad_tv_callback(const struct dmi_system_id *id)
-{
-       DRM_DEBUG_KMS("Ignoring bad SDVO TV connector for %s\n", id->ident);
-       return 1;
-}
-
-static struct dmi_system_id intel_sdvo_bad_tv[] = {
-       {
-               .callback = intel_sdvo_bad_tv_callback,
-               .ident = "IntelG45/ICH10R/DME1737",
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "IBM CORPORATION"),
-                       DMI_MATCH(DMI_PRODUCT_NAME, "4800784"),
-               },
-       },
-
-       { }     /* terminating entry */
-};
-
 static bool
 intel_sdvo_connector_alloc (struct intel_connector **ret)
 {
@@ -2396,7 +2376,7 @@ intel_sdvo_output_setup(struct intel_encoder *intel_encoder, uint16_t flags)
                        return false;
 
        /* TV has no XXX1 function block */
-       if ((flags & SDVO_OUTPUT_SVID0) && !dmi_check_system(intel_sdvo_bad_tv))
+       if (flags & SDVO_OUTPUT_SVID0)
                if (!intel_sdvo_tv_init(intel_encoder, SDVO_OUTPUT_SVID0))
                        return false;