phy: ti: j721e-wiz: Fix unreachable code in wiz_mode_select()

[ Upstream commit 57c0e1362fdd57d0cea7ab1e583b58abf4bd8c2d ]

In the wiz_mode_select() function, the configuration performed for
PHY_TYPE_USXGMII is unreachable. Fix it.

Fixes: b64a85fb8f53 ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20230403094552.929108-1-s-vadapalli@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 41725c6..6a63380 100644 (file)
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -422,18 +422,17 @@ static int wiz_mode_select(struct wiz *wiz)
        int i;
 
        for (i = 0; i < num_lanes; i++) {
-               if (wiz->lane_phy_type[i] == PHY_TYPE_DP)
+               if (wiz->lane_phy_type[i] == PHY_TYPE_DP) {
                        mode = LANE_MODE_GEN1;
-               else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII)
+               } else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) {
                        mode = LANE_MODE_GEN2;
-               else
-                       continue;
-
-               if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) {
+               } else if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) {
                        ret = regmap_field_write(wiz->p0_mac_src_sel[i], 0x3);
                        ret = regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3);
                        ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x3);
                        mode = LANE_MODE_GEN1;
+               } else {
+                       continue;
                }
 
                ret = regmap_field_write(wiz->p_standard_mode[i], mode);