power: reset: at91-reset: check properly the return value of devm_of_iomap
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Thu, 30 Sep 2021 10:09:28 +0000 (13:09 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:49 +0000 (19:16 +0100)
[ Upstream commit f558c8072c3461b65c12c0068b108f78cebc8246 ]

devm_of_iomap() returns error code or valid pointer. Check its return
value with IS_ERR().

Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap")
Reported-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/reset/at91-reset.c

index 0266494..64def79 100644 (file)
@@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL);
-       if (!reset->rstc_base) {
+       if (IS_ERR(reset->rstc_base)) {
                dev_err(&pdev->dev, "Could not map reset controller address\n");
                return -ENODEV;
        }
@@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
                for_each_matching_node_and_match(np, at91_ramc_of_match, &match) {
                        reset->ramc_lpr = (u32)match->data;
                        reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL);
-                       if (!reset->ramc_base[idx]) {
+                       if (IS_ERR(reset->ramc_base[idx])) {
                                dev_err(&pdev->dev, "Could not map ram controller address\n");
                                of_node_put(np);
                                return -ENODEV;