block/nbd: Fix the leaked visitor
authorAshijeet Acharya <ashijeetacharya@gmail.com>
Wed, 2 Nov 2016 10:40:03 +0000 (16:10 +0530)
committerKevin Wolf <kwolf@redhat.com>
Fri, 11 Nov 2016 14:54:55 +0000 (15:54 +0100)
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.

Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/nbd.c

index 9cff839..35f24be 100644 (file)
@@ -536,6 +536,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options)
     ov = qobject_output_visitor_new(&saddr_qdict);
     visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort);
     visit_complete(ov, &saddr_qdict);
+    visit_free(ov);
     assert(qobject_type(saddr_qdict) == QTYPE_QDICT);
 
     qdict_put_obj(opts, "server", saddr_qdict);