btrfs-progs: fix show super unknown flag output
authorZach Brown <zab@zabbo.net>
Wed, 15 Oct 2014 23:14:20 +0000 (16:14 -0700)
committerDavid Sterba <dsterba@suse.cz>
Thu, 16 Oct 2014 11:38:35 +0000 (13:38 +0200)
coverity pointed out that unknown flag printing in show super had some
dead code.  It turns out that first was reset when the first flag was
tested, not when it was output.  We only want to clear it if the first
matching bit is output.  If there are no matching bits then we'll want
to output the unknown flag first.

Signed-off-by: Zach Brown <zab@zabbo.net>
Signed-off-by: David Sterba <dsterba@suse.cz>
btrfs-show-super.c

index 456dbd8..2b48f44 100644 (file)
@@ -324,8 +324,8 @@ static void print_readable_incompat_flag(u64 flag)
                                printf("%s ", entry->output);
                        else
                                printf("|\n\t\t\t  %s ", entry->output);
+                       first = 0;
                }
-               first = 0;
        }
        flag &= ~BTRFS_FEATURE_INCOMPAT_SUPP;
        if (flag) {