readelf: Don't go past end of line data reading unknown opcode parameters.

https://sourceware.org/bugzilla/show_bug.cgi?id=24116

Signed-off-by: Mark Wielaard <mark@klomp.org>

diff --git a/src/ChangeLog b/src/ChangeLog
index 4ad12a9..0ea106c 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-22  Mark Wielaard  <mark@klomp.org>
+
+       * readelf.c (print_debug_line_section): Check we are not at end of
+       line data when reading parameters for unknown opcodes.
+
 2019-01-20  Mark Wielaard  <mark@klomp.org>
 
        * readelf.c (print_debug_line_section): Check terminating NUL byte

diff --git a/src/readelf.c b/src/readelf.c
index 6bad3bf..e3e699c 100644 (file)
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -8845,7 +8845,8 @@ print_debug_line_section (Dwfl_Module *dwflmod, Ebl *ebl, GElf_Ehdr *ehdr,
                                " unknown opcode with %" PRIu8 " parameters:",
                                standard_opcode_lengths[opcode]),
                      standard_opcode_lengths[opcode]);
-             for (int n = standard_opcode_lengths[opcode]; n > 0; --n)
+             for (int n = standard_opcode_lengths[opcode];
+                  n > 0 && linep < lineendp; --n)
                {
                  get_uleb128 (u128, linep, lineendp);
                  if (n != standard_opcode_lengths[opcode])