projects
/
platform
/
kernel
/
linux-rpi3.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bfe01a5
)
fs: Add a missing permission check to do_umount
author
Andy Lutomirski
<luto@amacapital.net>
Wed, 8 Oct 2014 19:32:47 +0000
(12:32 -0700)
committer
Andy Lutomirski
<luto@amacapital.net>
Wed, 8 Oct 2014 19:32:47 +0000
(12:32 -0700)
Accessing do_remount_sb should require global CAP_SYS_ADMIN, but
only one of the two call sites was appropriately protected.
Fixes CVE-2014-7975.
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
fs/namespace.c
patch
|
blob
|
history
diff --git
a/fs/namespace.c
b/fs/namespace.c
index
ef42d9b
..
7f67b46
100644
(file)
--- a/
fs/namespace.c
+++ b/
fs/namespace.c
@@
-1356,6
+1356,8
@@
static int do_umount(struct mount *mnt, int flags)
* Special case for "unmounting" root ...
* we just try to remount it readonly.
*/
+ if (!capable(CAP_SYS_ADMIN))
+ return -EPERM;
down_write(&sb->s_umount);
if (!(sb->s_flags & MS_RDONLY))
retval = do_remount_sb(sb, MS_RDONLY, NULL, 0);