iommu/vt-d: Adjust the return value of the parse_ioapics_under_ir
authorBaoquan He <bhe@redhat.com>
Thu, 22 Oct 2015 06:00:51 +0000 (14:00 +0800)
committerJoerg Roedel <jroedel@suse.de>
Fri, 23 Oct 2015 09:53:49 +0000 (11:53 +0200)
Adjust the return value of parse_ioapics_under_ir as
negative value representing failure and "0" representing
succcess. Just make it consistent with other function
implementations, and we can judge if calling is successfull
by if (!parse_ioapics_under_ir()) style.

Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/intel_irq_remapping.c

index a50468e..7843252 100644 (file)
@@ -690,7 +690,7 @@ static int __init intel_prepare_irq_remapping(void)
        if (!dmar_ir_support())
                return -ENODEV;
 
-       if (parse_ioapics_under_ir() != 1) {
+       if (!parse_ioapics_under_ir()) {
                pr_info("Not enabling interrupt remapping\n");
                goto error;
        }
@@ -943,7 +943,7 @@ static int __init parse_ioapics_under_ir(void)
                }
 
        if (!ir_supported)
-               return 0;
+               return -ENODEV;
 
        for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
                int ioapic_id = mpc_ioapic_id(ioapic_idx);
@@ -955,7 +955,7 @@ static int __init parse_ioapics_under_ir(void)
                }
        }
 
-       return 1;
+       return 0;
 }
 
 static int __init ir_dev_scope_init(void)