drivers/block/drbd: remove the null check for kmem_cache_destroy
authorzhong jiang <zhongjiang@huawei.com>
Wed, 8 Aug 2018 15:22:47 +0000 (23:22 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 8 Aug 2018 16:04:42 +0000 (10:04 -0600)
kmem_cache_destroy has taken null pointer into account. So it is
safe to drop the null check before calling the function.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_main.c

index a80809b..ef8212a 100644 (file)
@@ -2103,14 +2103,10 @@ static void drbd_destroy_mempools(void)
        mempool_exit(&drbd_md_io_page_pool);
        mempool_exit(&drbd_ee_mempool);
        mempool_exit(&drbd_request_mempool);
-       if (drbd_ee_cache)
-               kmem_cache_destroy(drbd_ee_cache);
-       if (drbd_request_cache)
-               kmem_cache_destroy(drbd_request_cache);
-       if (drbd_bm_ext_cache)
-               kmem_cache_destroy(drbd_bm_ext_cache);
-       if (drbd_al_ext_cache)
-               kmem_cache_destroy(drbd_al_ext_cache);
+       kmem_cache_destroy(drbd_ee_cache);
+       kmem_cache_destroy(drbd_request_cache);
+       kmem_cache_destroy(drbd_bm_ext_cache);
+       kmem_cache_destroy(drbd_al_ext_cache);
 
        drbd_ee_cache        = NULL;
        drbd_request_cache   = NULL;