microblaze: no need to reset handler if SA_ONESHOT
authorMatt Fleming <matt.fleming@intel.com>
Fri, 11 May 2012 00:58:04 +0000 (10:58 +1000)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 22 May 2012 03:52:33 +0000 (23:52 -0400)
get_signal_to_deliver() already resets the signal handler if SA_ONESHOT is
set in ka->sa.sa_flags, there's no need to do it again in handle_signal().
 Furthermore, because we were modifying ka->sa.sa_handler (which is a copy
of sighand->action[]) instead of sighand->action[] the original code
actually had no effect on signal delivery.

Acked-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/microblaze/kernel/signal.c

index 90de06d..9e749c0 100644 (file)
@@ -320,9 +320,6 @@ handle_signal(unsigned long sig, struct k_sigaction *ka,
        else
                setup_rt_frame(sig, ka, NULL, oldset, regs);
 
-       if (ka->sa.sa_flags & SA_ONESHOT)
-               ka->sa.sa_handler = SIG_DFL;
-
        if (!(ka->sa.sa_flags & SA_NODEFER)) {
                spin_lock_irq(&current->sighand->siglock);
                sigorsets(&current->blocked,