GFS2: smbd proccess hangs with flock() call.
authorAbhijith Das <adas@redhat.com>
Mon, 1 Jun 2009 17:30:03 +0000 (12:30 -0500)
committerSteven Whitehouse <swhiteho@redhat.com>
Tue, 2 Jun 2009 07:01:12 +0000 (08:01 +0100)
GFS2 currently does not support mandatory flocks. An flock() call with
LOCK_MAND triggers unexpected behavior because gfs2 is not checking for
this lock type. This patch corrects that.

Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/file.c

index 73b6f55..841ddc9 100644 (file)
@@ -698,8 +698,8 @@ static int gfs2_flock(struct file *file, int cmd, struct file_lock *fl)
 
        if (!(fl->fl_flags & FL_FLOCK))
                return -ENOLCK;
-       if (__mandatory_lock(&ip->i_inode))
-               return -ENOLCK;
+       if (fl->fl_type & LOCK_MAND)
+               return -EOPNOTSUPP;
 
        if (fl->fl_type == F_UNLCK) {
                do_unflock(file, fl);