sony-laptop: correct find_snc_handle failure checks
authorMattia Dongili <malattia@linux.it>
Wed, 13 Jun 2012 21:36:02 +0000 (06:36 +0900)
committerMatthew Garrett <mjg@redhat.com>
Tue, 26 Jun 2012 18:43:39 +0000 (14:43 -0400)
Since bab7084c745bf4d75b760728387f375fd34dc683, find_snc_handle
returns -EINVAL, not -1.

Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/sony-laptop.c

index b9499b6..d456ff0 100644 (file)
@@ -2555,19 +2555,19 @@ static void sony_nc_backlight_setup(void)
        const struct backlight_ops *ops = NULL;
        struct backlight_properties props;
 
-       if (sony_find_snc_handle(0x12f) != -1) {
+       if (sony_find_snc_handle(0x12f) >= 0) {
                ops = &sony_backlight_ng_ops;
                sony_bl_props.cmd_base = 0x0100;
                sony_nc_backlight_ng_read_limits(0x12f, &sony_bl_props);
                max_brightness = sony_bl_props.maxlvl - sony_bl_props.offset;
 
-       } else if (sony_find_snc_handle(0x137) != -1) {
+       } else if (sony_find_snc_handle(0x137) >= 0) {
                ops = &sony_backlight_ng_ops;
                sony_bl_props.cmd_base = 0x0100;
                sony_nc_backlight_ng_read_limits(0x137, &sony_bl_props);
                max_brightness = sony_bl_props.maxlvl - sony_bl_props.offset;
 
-       } else if (sony_find_snc_handle(0x143) != -1) {
+       } else if (sony_find_snc_handle(0x143) >= 0) {
                ops = &sony_backlight_ng_ops;
                sony_bl_props.cmd_base = 0x3000;
                sony_nc_backlight_ng_read_limits(0x143, &sony_bl_props);