projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3cfc2c4
)
HID: picolcd: testing the wrong variable
author
Dan Carpenter
<error27@gmail.com>
Fri, 6 Aug 2010 12:51:10 +0000
(14:51 +0200)
committer
Jiri Kosina
<jkosina@suse.cz>
Fri, 6 Aug 2010 12:51:10 +0000
(14:51 +0200)
"ref_cnt" is a point to the reference count and it's non-null. We really
want to test the reference count itself.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-picolcd.c
patch
|
blob
|
history
diff --git
a/drivers/hid/hid-picolcd.c
b/drivers/hid/hid-picolcd.c
index
346f0e3
..
c0bdeba
100644
(file)
--- a/
drivers/hid/hid-picolcd.c
+++ b/
drivers/hid/hid-picolcd.c
@@
-547,7
+547,7
@@
static void picolcd_fb_destroy(struct fb_info *info)
ref_cnt--;
mutex_lock(&info->lock);
(*ref_cnt)--;
- may_release = !ref_cnt;
+ may_release = !
*
ref_cnt;
mutex_unlock(&info->lock);
if (may_release) {
framebuffer_release(info);