x86/unwind/orc: Fix error path for bad ORC entry type
authorJosh Poimboeuf <jpoimboe@redhat.com>
Sat, 25 Apr 2020 10:06:13 +0000 (05:06 -0500)
committerIngo Molnar <mingo@kernel.org>
Sat, 25 Apr 2020 10:22:29 +0000 (12:22 +0200)
If the ORC entry type is unknown, nothing else can be done other than
reporting an error.  Exit the function instead of breaking out of the
switch statement.

Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Jones <dsj@fb.com>
Cc: Jann Horn <jannh@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lore.kernel.org/r/a7fa668ca6eabbe81ab18b2424f15adbbfdc810a.1587808742.git.jpoimboe@redhat.com
arch/x86/kernel/unwind_orc.c

index cb11567361cc8e3ef5f474a91afe49ea4ea5c139..33b80a7f998f8630a0297eb51fb2d2110c21efcf 100644 (file)
@@ -537,7 +537,7 @@ bool unwind_next_frame(struct unwind_state *state)
        default:
                orc_warn("unknown .orc_unwind entry type %d at %pB\n",
                         orc->type, (void *)orig_ip);
-               break;
+               goto err;
        }
 
        /* Find BP: */