Fix issue detected by static analysis tool

Memory leak found in case that ret is false.

Change-Id: I99bc47e878ca93e4b213e2f04ba366be24ae2b81

diff --git a/scl/xml_parser_utils.cpp b/scl/xml_parser_utils.cpp
index 5ec17c0..337fbb7 100644 (file)
--- a/scl/xml_parser_utils.cpp
+++ b/scl/xml_parser_utils.cpp
@@ -88,9 +88,11 @@ get_prop_bool(const xmlNodePtr cur_node, const char* prop, sclboolean *ret) {
         } else {
             *ret = false;
         }
-        xmlFree(key);
     }
 
+    if (key)
+        xmlFree(key);
+
     return succeeded;
 }
 

diff --git a/scl/xml_parser_utils.h b/scl/xml_parser_utils.h
index b72faf2..8779686 100644 (file)
--- a/scl/xml_parser_utils.h
+++ b/scl/xml_parser_utils.h
@@ -41,9 +41,11 @@ bool get_prop_number(const xmlNodePtr cur_node, const char* prop, T *ret) {
     if (ret && key != NULL) {
         succeeded = true;
         *ret = (T)atoi((const char*)key);
-        xmlFree(key);
     }
 
+    if (key)
+        xmlFree(key);
+
     return succeeded;
 }
 bool get_prop_bool(const xmlNodePtr cur_node, const char* prop, sclboolean *ret);