irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 2 Jan 2023 08:56:10 +0000 (12:56 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:00 +0000 (09:33 +0100)
[ Upstream commit 02298b7bae12936ca313975b02e7f98b06670d37 ]

of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: cd844b0715ce ("irqchip/ti-sci-intr: Add support for Interrupt Router driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230102085611.3955984-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-ti-sci-intr.c

index fe8fad2..020ddf2 100644 (file)
@@ -236,6 +236,7 @@ static int ti_sci_intr_irq_domain_probe(struct platform_device *pdev)
        }
 
        parent_domain = irq_find_host(parent_node);
+       of_node_put(parent_node);
        if (!parent_domain) {
                dev_err(dev, "Failed to find IRQ parent domain\n");
                return -ENODEV;