ALSA: gus: fix null pointer dereference on pointer block
authorChengfeng Ye <cyeaa@connect.ust.hk>
Sun, 24 Oct 2021 10:46:11 +0000 (03:46 -0700)
committerTakashi Iwai <tiwai@suse.de>
Tue, 26 Oct 2021 06:02:16 +0000 (08:02 +0200)
The pointer block return from snd_gf1_dma_next_block could be
null, so there is a potential null pointer dereference issue.
Fix this by adding a null check before dereference.

Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Link: https://lore.kernel.org/r/20211024104611.9919-1-cyeaa@connect.ust.hk
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/gus/gus_dma.c

index a1c770d..6d664dd 100644 (file)
@@ -126,6 +126,8 @@ static void snd_gf1_dma_interrupt(struct snd_gus_card * gus)
        }
        block = snd_gf1_dma_next_block(gus);
        spin_unlock(&gus->dma_lock);
+       if (!block)
+               return;
        snd_gf1_dma_program(gus, block->addr, block->buf_addr, block->count, (unsigned short) block->cmd);
        kfree(block);
 #if 0