GitRepository.create_tag: use GitArgs class
authorMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Wed, 17 Dec 2014 15:37:27 +0000 (17:37 +0200)
committerMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Tue, 3 Mar 2015 08:07:48 +0000 (10:07 +0200)
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
gbp/git/repository.py

index beb6433ef963ee4336f852e78a264d09dc06d577..bc3364782cbd9da1233a0b0e753e228f51e22970 100644 (file)
@@ -712,14 +712,14 @@ class GitRepository(object):
         @param keyid: the GPG keyid used to sign the tag
         @type keyid: C{str}
         """
-        args = []
-        args += [ '-m', msg ] if msg else []
+        args = GitArgs()
+        args.add_true(msg, ['-m', msg])
         if sign:
-            args += [ '-s' ]
-            args += [ '-u', keyid ] if keyid else []
-        args += [ name ]
-        args += [ commit ] if commit else []
-        self._git_command("tag", args)
+            args.add('-s')
+            args.add_true(keyid, ['-u', keyid])
+        args.add(name)
+        args.add_true(commit, commit)
+        self._git_command("tag", args.args)
 
     def delete_tag(self, tag):
         """