Remove VerticalTextAlignment functionality in Label
authorSeungkeun Lee <sngn.lee@samsung.com>
Wed, 5 Apr 2017 04:38:22 +0000 (13:38 +0900)
committerKangho Hur <kangho.hur@samsung.com>
Mon, 10 Jul 2017 02:11:22 +0000 (11:11 +0900)
 - EFL dose not support yet
 - Remove VerticalTextAlignment property in Native.Span
   it was wrong implemented, valign in EFL is semantically different from Xamarin.Forms VerticalTextAlignment
 - If provide VerticalTextAlignment API in EFL, this feature need to reimplement

Change-Id: I502700db74c7410529e46898578640abbd1253ef

Xamarin.Forms.Platform.Tizen/Native/Label.cs
Xamarin.Forms.Platform.Tizen/Native/Span.cs

index b81a24e..44eb5cb 100644 (file)
@@ -243,19 +243,9 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                /// <value>The vertical text alignment.</value>
                public TextAlignment VerticalTextAlignment
                {
-                       get
-                       {
-                               return _span.VerticalTextAlignment;
-                       }
-
-                       set
-                       {
-                               if (value != _span.VerticalTextAlignment)
-                               {
-                                       _span.VerticalTextAlignment = value;
-                                       ApplyTextAndStyle();
-                               }
-                       }
+                       // TODO. need to EFL new API
+                       get;
+                       set;
                }
 
                /// <summary>
index 99fe008..2f26649 100644 (file)
@@ -95,12 +95,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                public TextAlignment HorizontalTextAlignment { get; set; }
 
                /// <summary>
-               /// Gets or sets the vertical alignment mode for the text.
-               /// See <see cref="TextAlignment"/> for information about TextAlignment.
-               /// </summary>
-               public TextAlignment VerticalTextAlignment { get; set; }
-
-               /// <summary>
                /// Gets or sets the value that indicates whether the text has underline.
                /// </summary>
                public bool Underline { get; set; }
@@ -123,7 +117,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                        ForegroundColor = EColor.Default;
                        BackgroundColor = EColor.Default;
                        HorizontalTextAlignment = TextAlignment.None;
-                       VerticalTextAlignment = TextAlignment.None;
                        LineBreakMode = LineBreakMode.None;
                        Underline = false;
                        Strikethrough = false;
@@ -238,25 +231,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                                        break;
                        }
 
-                       switch (VerticalTextAlignment)
-                       {
-                               case TextAlignment.Auto:
-                               case TextAlignment.Start:
-                                       _formattingString.Append("valign=top ");
-                                       break;
-
-                               case TextAlignment.End:
-                                       _formattingString.Append("valign=bottom ");
-                                       break;
-
-                               case TextAlignment.Center:
-                                       _formattingString.Append("valign=middle ");
-                                       break;
-
-                               case TextAlignment.None:
-                                       break;
-                       }
-
                        switch (LineBreakMode)
                        {
                                case LineBreakMode.NoWrap: