ext4: code cleanup for ext4_statfs_project()
authorChengguang Xu <cgxu519@mykernel.net>
Mon, 10 Feb 2020 08:24:45 +0000 (16:24 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 5 Mar 2020 20:49:00 +0000 (15:49 -0500)
Calling min_not_zero() to simplify complicated prjquota
limit comparison in ext4_statfs_project().

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Link: https://lore.kernel.org/r/20200210082445.2379-1-cgxu519@mykernel.net
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c

index 0c7c4ad..de5398c 100644 (file)
@@ -5622,10 +5622,8 @@ static int ext4_statfs_project(struct super_block *sb,
                return PTR_ERR(dquot);
        spin_lock(&dquot->dq_dqb_lock);
 
-       limit = dquot->dq_dqb.dqb_bsoftlimit;
-       if (dquot->dq_dqb.dqb_bhardlimit &&
-           (!limit || dquot->dq_dqb.dqb_bhardlimit < limit))
-               limit = dquot->dq_dqb.dqb_bhardlimit;
+       limit = min_not_zero(dquot->dq_dqb.dqb_bsoftlimit,
+                            dquot->dq_dqb.dqb_bhardlimit);
        limit >>= sb->s_blocksize_bits;
 
        if (limit && buf->f_blocks > limit) {
@@ -5637,11 +5635,8 @@ static int ext4_statfs_project(struct super_block *sb,
                         (buf->f_blocks - curblock) : 0;
        }
 
-       limit = dquot->dq_dqb.dqb_isoftlimit;
-       if (dquot->dq_dqb.dqb_ihardlimit &&
-           (!limit || dquot->dq_dqb.dqb_ihardlimit < limit))
-               limit = dquot->dq_dqb.dqb_ihardlimit;
-
+       limit = min_not_zero(dquot->dq_dqb.dqb_isoftlimit,
+                            dquot->dq_dqb.dqb_ihardlimit);
        if (limit && buf->f_files > limit) {
                buf->f_files = limit;
                buf->f_ffree =