NFC: trf7970a: Initialize when enabling RF
authorMark A. Greer <mgreer@animalcreek.com>
Tue, 2 Sep 2014 22:12:23 +0000 (15:12 -0700)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 7 Sep 2014 21:13:43 +0000 (23:13 +0200)
Currently, the trf7970a is reset & initialized only
when the pm_runtime resume hook is called.  Instead,
initialize it every time the RF is enabled to ensure
that the trf7970a is quiesced and in a known state
before being set up for another RF technology.

Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/trf7970a.c

index 9c0549d..ce9686c 100644 (file)
@@ -823,10 +823,18 @@ static void trf7970a_switch_rf_off(struct trf7970a *trf)
 
 static void trf7970a_switch_rf_on(struct trf7970a *trf)
 {
+       int ret;
+
        dev_dbg(trf->dev, "Switching rf on\n");
 
        pm_runtime_get_sync(trf->dev);
 
+       ret = trf7970a_init(trf);
+       if (ret) {
+               dev_err(trf->dev, "%s - Can't initialize: %d\n", __func__, ret);
+               return;
+       }
+
        trf->state = TRF7970A_ST_IDLE;
 }
 
@@ -1473,12 +1481,6 @@ static int trf7970a_pm_runtime_resume(struct device *dev)
 
        usleep_range(20000, 21000);
 
-       ret = trf7970a_init(trf);
-       if (ret) {
-               dev_err(dev, "%s - Can't initialize: %d\n", __func__, ret);
-               return ret;
-       }
-
        pm_runtime_mark_last_busy(dev);
 
        return 0;