usb: typec: fusb302: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 22 Sep 2022 13:48:06 +0000 (21:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2022 08:35:53 +0000 (10:35 +0200)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220922134806.2204579-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/fusb302.c

index ab89c01..b0699be 100644 (file)
@@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
        chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
        if (IS_ERR(chip->tcpm_port)) {
                fwnode_handle_put(chip->tcpc_dev.fwnode);
-               ret = PTR_ERR(chip->tcpm_port);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "cannot register tcpm port, ret=%d", ret);
+               ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
+                                   "cannot register tcpm port\n");
                goto destroy_workqueue;
        }