i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr
authorYingjoe Chen <yingjoe.chen@mediatek.com>
Tue, 7 May 2019 14:20:32 +0000 (22:20 +0800)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 27 May 2019 19:24:43 +0000 (21:24 +0200)
If I2C_M_RECV_LEN check failed, msgs[i].buf allocated by memdup_user
will not be freed. Pump index up so it will be freed.

Fixes: 838bfa6049fb ("i2c-dev: Add support for I2C_M_RECV_LEN")
Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-dev.c

index 3f7b9af..776f366 100644 (file)
@@ -283,6 +283,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,
                            msgs[i].len < 1 || msgs[i].buf[0] < 1 ||
                            msgs[i].len < msgs[i].buf[0] +
                                             I2C_SMBUS_BLOCK_MAX) {
+                               i++;
                                res = -EINVAL;
                                break;
                        }