spi: stm32: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 15:27:10 +0000 (17:27 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Sep 2020 17:19:29 +0000 (18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200901152713.18629-8-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32.c

index d4b33b3..f0e594b 100644 (file)
@@ -1857,9 +1857,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
 
        spi->irq = platform_get_irq(pdev, 0);
        if (spi->irq <= 0) {
-               ret = spi->irq;
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
+               ret = dev_err_probe(&pdev->dev, spi->irq, "failed to get irq\n");
                goto err_master_put;
        }
        ret = devm_request_threaded_irq(&pdev->dev, spi->irq,