macintosh/via-pmu-backlight: Use backlight helper
authorStephen Kitt <steve@sk2.org>
Thu, 16 Jun 2022 17:04:24 +0000 (19:04 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Nov 2022 12:12:17 +0000 (23:12 +1100)
backlight_properties.fb_blank is deprecated. The states it represents
are handled by other properties; but instead of accessing those
properties directly, drivers should use the helpers provided by
backlight.h.

Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.

Signed-off-by: Stephen Kitt <steve@sk2.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220616170425.1346081-1-steve@sk2.org
drivers/macintosh/via-pmu-backlight.c

index 2194016..c2d87e7 100644 (file)
@@ -71,12 +71,7 @@ static int pmu_backlight_get_level_brightness(int level)
 static int __pmu_backlight_update_status(struct backlight_device *bd)
 {
        struct adb_request req;
-       int level = bd->props.brightness;
-
-
-       if (bd->props.power != FB_BLANK_UNBLANK ||
-           bd->props.fb_blank != FB_BLANK_UNBLANK)
-               level = 0;
+       int level = backlight_get_brightness(bd);
 
        if (level > 0) {
                int pmulevel = pmu_backlight_get_level_brightness(level);