ASoC: tas571x: Kill BUG_ON() usage
authorTakashi Iwai <tiwai@suse.de>
Thu, 7 Sep 2017 08:59:16 +0000 (10:59 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 20 Sep 2017 11:45:19 +0000 (12:45 +0100)
Don't use BUG_ON() for a non-critical sanity check on production
systems.  This patch replaces with a softer WARN_ON() and an error
path.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas571x.c

index 810369f..a094999 100644 (file)
@@ -697,7 +697,8 @@ static int tas571x_i2c_probe(struct i2c_client *client,
                return PTR_ERR(priv->mclk);
        }
 
-       BUG_ON(priv->chip->num_supply_names > TAS571X_MAX_SUPPLIES);
+       if (WARN_ON(priv->chip->num_supply_names > TAS571X_MAX_SUPPLIES))
+               return -EINVAL;
        for (i = 0; i < priv->chip->num_supply_names; i++)
                priv->supplies[i].supply = priv->chip->supply_names[i];