drm/hisilicon: Use drm_mode_init() for on-stack modes
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 7 Nov 2022 19:25:40 +0000 (21:25 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 11 Nov 2022 23:36:43 +0000 (01:36 +0200)
Initialize on-stack modes with drm_mode_init() to guarantee
no stack garbage in the list head.

Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221107192545.9896-3-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

index a0d5aa7..d9978b7 100644 (file)
@@ -658,7 +658,7 @@ static enum drm_mode_status dsi_encoder_mode_valid(struct drm_encoder *encoder,
                 * reset adj_mode to the mode value each time,
                 * so we don't adjust the mode twice
                 */
-               drm_mode_copy(&adj_mode, mode);
+               drm_mode_init(&adj_mode, mode);
 
                crtc_funcs = crtc->helper_private;
                if (crtc_funcs && crtc_funcs->mode_fixup)