power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Mon, 13 Apr 2020 14:10:51 +0000 (16:10 +0200)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:20 +0000 (15:38 -0400)
[ Upstream commit 87c3d579c8ed0eaea6b1567d529a8daa85a2bc6c ]

regmap is a library function that gets selected by drivers that need
it. No driver modules should depend on it. Depending on REGMAP_I2C makes
this driver only build if another driver already selected REGMAP_I2C,
as the symbol can't be selected through the menu kernel configuration.

Fixes: 2219a935963e ("power_supply: Add TI BQ24257 charger driver")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/supply/Kconfig

index 76806a0..0de9a95 100644 (file)
@@ -424,7 +424,7 @@ config CHARGER_BQ24257
        tristate "TI BQ24250/24251/24257 battery charger driver"
        depends on I2C
        depends on GPIOLIB || COMPILE_TEST
-       depends on REGMAP_I2C
+       select REGMAP_I2C
        help
          Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery
          chargers.