projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7ec0777
)
net: ethtool: fix __ethtool_dev_mm_supported() implementation
author
Vladimir Oltean
<vladimir.oltean@nxp.com>
Mon, 20 Feb 2023 12:23:31 +0000
(14:23 +0200)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 21 Feb 2023 17:05:01 +0000
(09:05 -0800)
The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.
Link:
https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu>
Link:
https://lore.kernel.org/all/20230220122343.1156614-2-vladimir.oltean@nxp.com/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/mm.c
patch
|
blob
|
history
diff --git
a/net/ethtool/mm.c
b/net/ethtool/mm.c
index e612856eed8ceebadad9ed9164bad9a8fc4665d2..fce3cc2734f9bfba99191e9e9ed271b4e15ac49c 100644
(file)
--- a/
net/ethtool/mm.c
+++ b/
net/ethtool/mm.c
@@
-247,5
+247,5
@@
bool __ethtool_dev_mm_supported(struct net_device *dev)
if (ops && ops->get_mm)
ret = ops->get_mm(dev, &state);
- return !
!
ret;
+ return !ret;
}