Oops, refactoring error in commit 327701572ff912413ec9564d29d946b4ab21a9f3

- sizeof() doesn't work very well for malloced arrays... not that it
  matters a whole lot, this isn't a path that will ever be executed
  afaict.

diff --git a/lib/fprint.c b/lib/fprint.c
index f370b37..3252048 100644 (file)
--- a/lib/fprint.c
+++ b/lib/fprint.c
@@ -166,7 +166,7 @@ static int doLookupId(fingerPrintCache cache,
        if (realpath(".", cdnbuf) != NULL) {
            end = cdnbuf + strlen(cdnbuf);
            if (end[-1] != '/') *end++ = '/';
-           end = stpncpy(end, dirName, sizeof(cdnbuf) - (end - cdnbuf));
+           end = stpncpy(end, dirName, PATH_MAX - (end - cdnbuf));
            *end = '\0';
            (void)rpmCleanPath(cdnbuf); /* XXX possible /../ from concatenation */
            end = cdnbuf + strlen(cdnbuf);