Remove SkLights include from SkCanvas.h
authorFlorin Malita <fmalita@chromium.org>
Mon, 1 May 2017 17:22:11 +0000 (13:22 -0400)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Tue, 2 May 2017 14:50:38 +0000 (14:50 +0000)
SkLights.h pulls in a bunch of other headers and is not needed (fwdecl
works fine).

Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f
Reviewed-on: https://skia-review.googlesource.com/14904
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

46 files changed:
bench/ColorCanvasDrawBitmapBench.cpp
bench/DrawBitmapAABench.cpp
bench/DrawLatticeBench.cpp
bench/ImageFilterDAGBench.cpp
bench/MagnifierBench.cpp
bench/ReadPixBench.cpp
bench/ShaderMaskBench.cpp
bench/WritePixelsBench.cpp
gm/bitmapimage.cpp
gm/colorspacexform.cpp
gm/composeshader.cpp
gm/deferredtextureimage.cpp
gm/encode-platform.cpp
gm/encode-srgb.cpp
gm/encode.cpp
gm/gammaencodedpremul.cpp
gm/subsetshader.cpp
include/core/SkCanvas.h
include/private/SkRecords.h
samplecode/SampleAAGeometry.cpp
samplecode/SampleAnimatedText.cpp
samplecode/SampleLayerMask.cpp
src/core/SkCanvas.cpp
src/core/SkDraw.h
src/core/SkLiteDL.cpp
src/core/SkLiteDL.h
src/core/SkPictureCommon.h
src/core/SkRecord.cpp
src/core/SkRecordDraw.cpp
src/fonts/SkRandomScalerContext.cpp
src/pdf/SkPDFCanvas.cpp
src/utils/SkDumpCanvas.cpp
src/utils/SkShadowPaintFilterCanvas.h
src/utils/SkShadowUtils.cpp
tests/CanvasStateTest.cpp
tests/ClipCubicTest.cpp
tests/ClipperTest.cpp
tests/EmptyPathTest.cpp
tests/HighContrastFilterTest.cpp
tests/PictureBBHTest.cpp
tests/SpecialSurfaceTest.cpp
tools/debugger/SkDrawCommand.h
tools/dump_record.cpp
tools/ok.cpp
tools/ok_srcs.cpp
tools/ok_vias.cpp

index de13ba2..c150e79 100644 (file)
@@ -6,6 +6,7 @@
 */
 
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkColorSpaceXformCanvas.h"
 #include "SkString.h"
index 011c30a..f0ccd89 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkMatrix.h"
 #include "SkPaint.h"
index 806815b..7a8cdf3 100644 (file)
@@ -6,6 +6,7 @@
 */
 
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkRect.h"
 #include "SkString.h"
index 719e87b..350510b 100644 (file)
@@ -10,6 +10,7 @@
 #include "SkBlurImageFilter.h"
 #include "SkDisplacementMapEffect.h"
 #include "SkCanvas.h"
+#include "SkImage.h"
 #include "SkMergeImageFilter.h"
 
 
index 98deade..6403aa6 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkMagnifierImageFilter.h"
 #include "SkRandom.h"
index 2efb19c..2a8e9c4 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 
 
index 8fd99b6..1cc2347 100644 (file)
@@ -9,6 +9,7 @@
 #include "SkCanvas.h"
 #include "SkPaint.h"
 #include "SkRandom.h"
+#include "SkShader.h"
 #include "SkString.h"
 #include "SkTemplates.h"
 
index 5d6787e..4e2dbeb 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "Benchmark.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkString.h"
 
index 8c37d5d..be17af8 100644 (file)
@@ -8,6 +8,7 @@
 #include "gm.h"
 #include "Resources.h"
 #include "SkCodec.h"
+#include "SkImage.h"
 
 namespace skiagm {
 
index 4657f6a..eb98b01 100644 (file)
@@ -10,6 +10,7 @@
 #include "SkColorSpace_Base.h"
 #include "SkColorSpaceXform.h"
 #include "SkRect.h"
+#include "SkShader.h"
 
 class ColorSpaceXformGM : public skiagm::GM {
 public:
index 90fcedc..a6210c9 100644 (file)
@@ -10,6 +10,7 @@
 #include "SkCanvas.h"
 #include "SkGradientShader.h"
 #include "SkGraphics.h"
+#include "SkImage.h"
 #include "SkShader.h"
 #include "SkString.h"
 #include "SkTDArray.h"
index c88b878..9c1fe6a 100644 (file)
@@ -7,6 +7,7 @@
 #include <vector>
 
 #include "gm.h"
+#include "SkImage.h"
 #include "SkMipMap.h"
 #include "Resources.h"
 
index f08da73..17f27d5 100644 (file)
@@ -10,6 +10,7 @@
 #include "Resources.h"
 #include "SkCanvas.h"
 #include "SkData.h"
+#include "SkImage.h"
 #include "SkImageEncoderPriv.h"
 #include "SkUnPreMultiply.h"
 
index 3015baa..ab95757 100644 (file)
@@ -12,6 +12,7 @@
 #include "SkCodec.h"
 #include "SkColorSpace_Base.h"
 #include "SkData.h"
+#include "SkImage.h"
 #include "SkImageEncoderPriv.h"
 #include "SkPM4f.h"
 #include "SkSRGB.h"
index 1dae1bf..bf13d3d 100644 (file)
@@ -8,6 +8,7 @@
 #include "sk_tool_utils.h"
 #include "SkCanvas.h"
 #include "SkData.h"
+#include "SkImage.h"
 #include "SkImageEncoder.h"
 #include "Resources.h"
 
index 327368f..d55498b 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "gm.h"
+#include "SkColorPriv.h"
 #include "SkColorSpaceXform.h"
 #include "SkColorSpaceXformPriv.h"
 #include "SkOpts.h"
index c4ef5f7..a7029f4 100644 (file)
@@ -7,6 +7,7 @@
 
 #include "Resources.h"
 #include "SkBitmap.h"
+#include "SkShader.h"
 #include "gm.h"
 
 DEF_SIMPLE_GM(bitmap_subset_shader, canvas, 256, 256) {
index 837b2ff..8edc36d 100644 (file)
@@ -14,7 +14,6 @@
 #include "SkPaint.h"
 #include "SkRasterHandleAllocator.h"
 #include "SkSurfaceProps.h"
-#include "SkLights.h"
 #include "../private/SkShadowParams.h"
 
 class GrContext;
@@ -28,6 +27,7 @@ class SkDrawable;
 class SkDrawFilter;
 class SkImage;
 class SkImageFilter;
+class SkLights;
 class SkMetaData;
 class SkPath;
 class SkPicture;
index 4d7b217..d8f392a 100644 (file)
@@ -11,6 +11,7 @@
 #include "SkData.h"
 #include "SkCanvas.h"
 #include "SkDrawable.h"
+#include "SkImage.h"
 #include "SkImageFilter.h"
 #include "SkMatrix.h"
 #include "SkPath.h"
index 6f6541b..69aa77f 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "SampleCode.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkGeometry.h"
 #include "SkIntersections.h"
index e70530a..29bd192 100644 (file)
@@ -11,6 +11,7 @@
 #include "SkUtils.h"
 #include "SkColorPriv.h"
 #include "SkColorFilter.h"
+#include "SkImage.h"
 #include "SkRandom.h"
 #include "SkSystemEventTypes.h"
 #include "SkTime.h"
index f0c6a40..b039421 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "SampleCode.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkPaint.h"
 #include "SkPath.h"
index c09e6cb..ad03f73 100644 (file)
@@ -20,6 +20,7 @@
 #include "SkImageFilter.h"
 #include "SkImageFilterCache.h"
 #include "SkLatticeIter.h"
+#include "SkLights.h"
 #include "SkMakeUnique.h"
 #include "SkMatrixUtils.h"
 #include "SkMetaData.h"
index b142e7e..f2d5946 100644 (file)
@@ -13,6 +13,7 @@
 #include "SkCanvas.h"
 #include "SkMask.h"
 #include "SkPaint.h"
+#include "SkPixmap.h"
 #include "SkStrokeRec.h"
 #include "SkVertices.h"
 
index 71cbf68..4d3a5f9 100644 (file)
@@ -8,6 +8,7 @@
 #include "SkCanvas.h"
 #include "SkData.h"
 #include "SkDrawFilter.h"
+#include "SkImage.h"
 #include "SkImageFilter.h"
 #include "SkLiteDL.h"
 #include "SkMath.h"
index f8e7910..c88a86d 100644 (file)
@@ -14,6 +14,7 @@
 #include "SkDrawable.h"
 #include "SkRect.h"
 #include "SkTDArray.h"
+#include "SkTemplates.h"
 
 class SkLiteDL final {
 public:
index 6f6a9f1..a400264 100644 (file)
@@ -14,6 +14,7 @@
 
 #include "SkPathEffect.h"
 #include "SkRecords.h"
+#include "SkShader.h"
 #include "SkTLogic.h"
 
 // N.B. This name is slightly historical: hunting season is now open for SkImages too.
index 4df4131..3553ff5 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "SkRecord.h"
+#include "SkImage.h"
 #include <algorithm>
 
 SkRecord::~SkRecord() {
index 9e8d6fc..7999be3 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "SkRecordDraw.h"
+#include "SkImage.h"
 #include "SkPatchUtils.h"
 
 void SkRecordDraw(const SkRecord& record,
index 3a292dc..a38f695 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkGlyph.h"
 #include "SkMakeUnique.h"
index d946f48..c5cde3d 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkImage.h"
 #include "SkLatticeIter.h"
 #include "SkPDFCanvas.h"
 #include "SkPDFDevice.h"
index 35b88de..05cabad 100644 (file)
@@ -7,6 +7,7 @@
 
 #include "SkData.h"
 #include "SkDumpCanvas.h"
+#include "SkImage.h"
 #include "SkPatchUtils.h"
 #include "SkPicture.h"
 #include "SkPixelRef.h"
index 190c68b..a03e000 100644 (file)
@@ -8,6 +8,7 @@
 #ifndef SkShadowPaintFilterCanvas_DEFINED
 #define SkShadowPaintFilterCanvas_DEFINED
 
+#include "SkLights.h"
 #include "SkPaintFilterCanvas.h"
 
 #ifdef SK_EXPERIMENTAL_SHADOWING
index 928eb66..6ea5566 100644 (file)
@@ -8,6 +8,7 @@
 #include "SkShadowUtils.h"
 #include "SkCanvas.h"
 #include "SkColorFilter.h"
+#include "SkColorPriv.h"
 #include "SkPath.h"
 #include "SkRandom.h"
 #include "SkResourceCache.h"
index 73c8a0e..ae417d4 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "CanvasStateHelpers.h"
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkClipOpPriv.h"
 #include "SkCanvasStateUtils.h"
index 1d88eae..854ac32 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkCubicClipper.h"
 #include "SkGeometry.h"
@@ -165,41 +166,41 @@ DEF_TEST(ClipCubic, reporter) {
 
 #include "SkSurface.h"
 
-DEF_TEST(test_fuzz_crbug_698714, reporter) {\r
-    auto surface(SkSurface::MakeRasterN32Premul(500, 500));\r
-    SkCanvas* canvas = surface->getCanvas();\r
-    SkPaint paint;\r
-    paint.setAntiAlias(true);\r
-    SkPath path;\r
-    path.setFillType(SkPath::kWinding_FillType);\r
-    path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0,0\r
-    path.lineTo(SkBits2Float(0x43434343), SkBits2Float(0x43430143));  //195.263f, 195.005f\r
-    path.lineTo(SkBits2Float(0x43434343), SkBits2Float(0x43434343));  //195.263f, 195.263f\r
-    path.lineTo(SkBits2Float(0xb5434343), SkBits2Float(0x434300be));  //-7.2741e-07f, 195.003f\r
-    // 195.263f, 195.263f, -1.16387e-05f, 3.58641e-38f, 3.85088e-29f,1.86082e-39f\r
-    path.cubicTo(SkBits2Float(0x43434343), SkBits2Float(0x43434341),\r
-            SkBits2Float(0xb74343bd), SkBits2Float(0x01434343),\r
-            SkBits2Float(0x10434343), SkBits2Float(0x00144332));\r
-    // 4.11823e-38f, 195.263f, 195.263f, 195.263f, -7.2741e-07f, 195.263f\r
-    path.cubicTo(SkBits2Float(0x016037c0), SkBits2Float(0x43434343),\r
-            SkBits2Float(0x43434343), SkBits2Float(0x43434343),\r
-            SkBits2Float(0xb5434343), SkBits2Float(0x43434343));\r
-    // 195.263f, 195.263f, -1.16387e-05f, 3.58641e-38f, 195.263f, -2\r
-    path.cubicTo(SkBits2Float(0x43434344), SkBits2Float(0x43434341),\r
-            SkBits2Float(0xb74343bd), SkBits2Float(0x01434343),\r
-            SkBits2Float(0x43434343), SkBits2Float(0xc0000014));\r
-    // -5.87228e+06f, 3.7773e-07f, 3.60231e-13f, -6.64511e+06f,2.77692e-15f, 2.48803e-15f\r
-    path.cubicTo(SkBits2Float(0xcab33535), SkBits2Float(0x34cacaca),\r
-            SkBits2Float(0x2acacaca), SkBits2Float(0xcacacae3),\r
-            SkBits2Float(0x27481927), SkBits2Float(0x27334805));\r
-    path.lineTo(SkBits2Float(0xb5434343), SkBits2Float(0x43434343));  //-7.2741e-07f, 195.263f\r
-    // 195.263f, 195.263f, -1.16387e-05f, 195.212f, 195.263f, -2\r
-    path.cubicTo(SkBits2Float(0x43434343), SkBits2Float(0x43434341),\r
-            SkBits2Float(0xb74343b9), SkBits2Float(0x43433643),\r
-            SkBits2Float(0x43434343), SkBits2Float(0xc0000014));\r
-    path.lineTo(SkBits2Float(0xc7004343), SkBits2Float(0x27480527));  //-32835.3f, 2.77584e-15f\r
-    path.lineTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0,0\r
-    path.close();\r
-    canvas->clipRect({0, 0, 65, 202});\r
-    canvas->drawPath(path, paint);\r
-}\r
+DEF_TEST(test_fuzz_crbug_698714, reporter) {
+    auto surface(SkSurface::MakeRasterN32Premul(500, 500));
+    SkCanvas* canvas = surface->getCanvas();
+    SkPaint paint;
+    paint.setAntiAlias(true);
+    SkPath path;
+    path.setFillType(SkPath::kWinding_FillType);
+    path.moveTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0,0
+    path.lineTo(SkBits2Float(0x43434343), SkBits2Float(0x43430143));  //195.263f, 195.005f
+    path.lineTo(SkBits2Float(0x43434343), SkBits2Float(0x43434343));  //195.263f, 195.263f
+    path.lineTo(SkBits2Float(0xb5434343), SkBits2Float(0x434300be));  //-7.2741e-07f, 195.003f
+    // 195.263f, 195.263f, -1.16387e-05f, 3.58641e-38f, 3.85088e-29f,1.86082e-39f
+    path.cubicTo(SkBits2Float(0x43434343), SkBits2Float(0x43434341),
+            SkBits2Float(0xb74343bd), SkBits2Float(0x01434343),
+            SkBits2Float(0x10434343), SkBits2Float(0x00144332));
+    // 4.11823e-38f, 195.263f, 195.263f, 195.263f, -7.2741e-07f, 195.263f
+    path.cubicTo(SkBits2Float(0x016037c0), SkBits2Float(0x43434343),
+            SkBits2Float(0x43434343), SkBits2Float(0x43434343),
+            SkBits2Float(0xb5434343), SkBits2Float(0x43434343));
+    // 195.263f, 195.263f, -1.16387e-05f, 3.58641e-38f, 195.263f, -2
+    path.cubicTo(SkBits2Float(0x43434344), SkBits2Float(0x43434341),
+            SkBits2Float(0xb74343bd), SkBits2Float(0x01434343),
+            SkBits2Float(0x43434343), SkBits2Float(0xc0000014));
+    // -5.87228e+06f, 3.7773e-07f, 3.60231e-13f, -6.64511e+06f,2.77692e-15f, 2.48803e-15f
+    path.cubicTo(SkBits2Float(0xcab33535), SkBits2Float(0x34cacaca),
+            SkBits2Float(0x2acacaca), SkBits2Float(0xcacacae3),
+            SkBits2Float(0x27481927), SkBits2Float(0x27334805));
+    path.lineTo(SkBits2Float(0xb5434343), SkBits2Float(0x43434343));  //-7.2741e-07f, 195.263f
+    // 195.263f, 195.263f, -1.16387e-05f, 195.212f, 195.263f, -2
+    path.cubicTo(SkBits2Float(0x43434343), SkBits2Float(0x43434341),
+            SkBits2Float(0xb74343b9), SkBits2Float(0x43433643),
+            SkBits2Float(0x43434343), SkBits2Float(0xc0000014));
+    path.lineTo(SkBits2Float(0xc7004343), SkBits2Float(0x27480527));  //-32835.3f, 2.77584e-15f
+    path.lineTo(SkBits2Float(0x00000000), SkBits2Float(0x00000000));  // 0,0
+    path.close();
+    canvas->clipRect({0, 0, 65, 202});
+    canvas->drawPath(path, paint);
+}
index 8ebd9b4..641ed01 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkEdgeClipper.h"
 #include "SkLineClipper.h"
index 060ef8d..5b857a0 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkPath.h"
 #include "Test.h"
index 26f1a7c..7c3fc84 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkHighContrastFilter.h"
 #include "Test.h"
index 64b09b1..0bc81c2 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkBBoxHierarchy.h"
 #include "SkPaint.h"
index 1867e25..a336cf6 100644 (file)
@@ -5,6 +5,7 @@
 * found in the LICENSE file
 */
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkSpecialImage.h"
 #include "SkSpecialSurface.h"
index 4004b3b..fc15526 100644 (file)
@@ -8,6 +8,7 @@
 #ifndef SKDRAWCOMMAND_H_
 #define SKDRAWCOMMAND_H_
 
+#include "SkBitmap.h"
 #include "SkCanvas.h"
 #include "SkTLazy.h"
 #include "SkPath.h"
index c1b87e7..24017bd 100644 (file)
@@ -6,6 +6,7 @@
  */
 
 #include "DumpRecord.h"
+#include "SkBitmap.h"
 #include "SkCommandLineFlags.h"
 #include "SkDeferredCanvas.h"
 #include "SkPicture.h"
index 10f9afd..edda9be 100644 (file)
@@ -10,6 +10,7 @@
 //   * ok is entirely opt-in.  No more maintaining huge --blacklists.
 
 #include "SkGraphics.h"
+#include "SkImage.h"
 #include "ok.h"
 #include <chrono>
 #include <future>
index fd5f201..5630a34 100644 (file)
@@ -7,6 +7,7 @@
 
 #include "ok.h"
 #include "gm.h"
+#include "SkData.h"
 #include "SkOSFile.h"
 #include "SkPicture.h"
 #include <vector>
index 17e117a..20779cf 100644 (file)
@@ -5,6 +5,7 @@
  * found in the LICENSE file.
  */
 
+#include "SkImage.h"
 #include "SkOSFile.h"
 #include "SkPictureRecorder.h"
 #include "ok.h"