Fix off-by-one error in complaint_internal

complaint_internal had an off-by-one error, where it would allow one
extra complaint to be issued.

gdb/ChangeLog
2018-10-04  Tom Tromey  <tom@tromey.com>

	* complaints.c (complaint_internal): Correctly check complaint
	count.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5ee22e6..14ef35f 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-10-04  Tom Tromey  <tom@tromey.com>
 
+       * complaints.c (complaint_internal): Correctly check complaint
+       count.
+
+2018-10-04  Tom Tromey  <tom@tromey.com>
+
        * complaints.h (struct complaints): Remove declaration.
        * complaints.c (clear_complaints): Remove an unused variable.
 

diff --git a/gdb/complaints.c b/gdb/complaints.c
index 03102f1..43ea7a1 100644 (file)
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -56,7 +56,7 @@ complaint_internal (const char *fmt, ...)
 {
   va_list args;
 
-  if (counters[fmt]++ > stop_whining)
+  if (++counters[fmt] > stop_whining)
     return;
 
   va_start (args, fmt);